Fix the building error in android_deploy #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
requested changes
Jun 12, 2018
src/runtime/thread_pool.cc
Outdated
| @@ -69,14 +69,14 @@ class ParallelLauncher { | |||
| tvm::runtime::threading::Yield(); | |||
| } | |||
| if (!has_error_.load()) return 0; | |||
| std::string err(""); | |||
| std::stringstream err; | |||
There was a problem hiding this comment.
this is intended to use string, due to security issues raised in SGX backend, please revert this change and add a comment about it
There was a problem hiding this comment.
std::stringstream was banned by sgx backend and we need it here
There was a problem hiding this comment.
I reverted this change and add a comment. Then I changed APP_STL to avoid the building error. Please review again.
tqchen
approved these changes
Jun 12, 2018
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Jul 6, 2018
* Fix a link in android_deploy/README.md and a error while building android_deploy. * revert and change APP_STL in Application.mk
mnuyens
pushed a commit
to mnuyens/tvm
that referenced
this pull request
Jul 10, 2018
* Fix a link in android_deploy/README.md and a error while building android_deploy. * revert and change APP_STL in Application.mk
sergei-mironov
pushed a commit
to sergei-mironov/tvm
that referenced
this pull request
Aug 8, 2018
* Fix a link in android_deploy/README.md and a error while building android_deploy. * revert and change APP_STL in Application.mk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following error while doing
gradle buildand the document url in README.Please review. @tqchen @PariksheetPinjari909