Remove Incorrect Extension Registration of tvm::Target #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kazum this change causes a following error in osx: |
|
@nishi-t Thanks for your comment. It looks like clang doesn't support -Bsymbolic-functions option. |
kazum
force-pushed
the
bsymbolic-functions-for-cmake
branch
from
0419532
to
4c3e4a8
Compare
|
Sorry I didn't take a closer look. This actually reveals a BUG that needs to be fixed. Specifically, tvm::Target is no longer an extension type, but a node type now, and we should remove the extension registeration here https://github.com/dmlc/tvm/blob/master/topi/src/topi.cc#L50 |
tqchen
changed the title
|
@tqchen Okay, I'll fix the problem based on your comment, thanks. |
kazum
force-pushed
the
bsymbolic-functions-for-cmake
branch
from
4c3e4a8
to
6d11057
Compare
tqchen
approved these changes
Jun 14, 2018
tqchen
added
status: accepted
and removed
status: need update
|
Thanks! this is merged |
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Jul 6, 2018
mnuyens
pushed a commit
to mnuyens/tvm
that referenced
this pull request
Jul 10, 2018
sergei-mironov
pushed a commit
to sergei-mironov/tvm
that referenced
this pull request
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1244 for CMake.
Here is an example configuration to produce the problem:
CMAKE_BUILD_TYPE=Debug
CMAKE_CXX_FLAGS_DEBUG="-g -O0"