[NVPTX] libdevice support, enable NVPTX backend in topi tests #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
changed the title
|
@tqchen ready for a review. can you have a look? |
tqchen
requested changes
Jul 3, 2018
| const Call* call = e.as<Call>(); | ||
| CHECK(call != nullptr); | ||
| std::ostringstream intrinsic_name; | ||
| intrinsic_name << "__nv_" << call->name << "f"; |
There was a problem hiding this comment.
Does this works for double type? The f suffix seems to be hardcoded for float32
There was a problem hiding this comment.
Need to dispatch by type to support double type
src/codegen/llvm/codegen_nvptx.cc
Outdated
| if (fname.substr(0, 4) != "__nv") continue; | ||
| // This is to strip off unused __nv_* functions from the final module | ||
| // The one that is actually used will be inlined at call site | ||
| // See Halide's LLVM_Runtime_Linker.cpp |
There was a problem hiding this comment.
See Halide's LLVM_Runtime_Linker.cpp -> adopted from Halide's runtime linker. if you have referred to the code
tqchen
added
status: review in progress
status: need update
tqchen
requested changes
Jul 3, 2018
src/codegen/llvm/codegen_nvptx.cc
Outdated
| if (fname.substr(0, 4) != "__nv") continue; | ||
| // This is to strip off unused __nv_* functions from the final module | ||
| // The one that is actually used will be inlined at call site | ||
| // Adopted from Halide's runtime linker |
There was a problem hiding this comment.
sorry, adopted-> adapted, my mistake on the previous comment
tqchen
approved these changes
Jul 3, 2018
|
@tqchen fixed lint and passed CI. Thanks for the review. |
tqchen
approved these changes
Jul 3, 2018
tqchen
added
status: accepted
and removed
status: need update
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Jul 6, 2018
mnuyens
pushed a commit
to mnuyens/tvm
that referenced
this pull request
Jul 10, 2018
sergei-mironov
pushed a commit
to sergei-mironov/tvm
that referenced
this pull request
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Math function support has been missing for NVPTX backend. This PR attempts to fix the final missing piece.
All topi tests pass with nvptx backend.