[TOPI][DARKNET]Yolo op added #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please request review from the reviewers |
|
@zhreshold @srkreddy1238 can you pls review this |
|
@Huyuwei pls review this |
|
Is yolo op particularly for yolov3? @PariksheetPinjari909 |
|
@zhreshold Yes, Yolo op is used only in yolov3. |
tqchen
added
status: need update
zhreshold
approved these changes
Jul 6, 2018
srkreddy1238
requested changes
Jul 6, 2018
topi/python/topi/vision/yolo/yolo.py
Outdated
| # pylint: disable=invalid-name, unused-variable | ||
| """ | ||
| YOLO Operator | ||
| ==================== |
There was a problem hiding this comment.
Should not exceed the text length above .
|
@PariksheetPinjari909 please fix according to @srkreddy1238 's comments |
|
@tqchen Review comments fixed. Pls check |
|
Thanks @PariksheetPinjari909 for the contribution. Thanks @srkreddy1238 and @zhreshold for helpful reviews, this is now merged! |
tqchen
added
status: accepted
and removed
status: need update
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Aug 4, 2018
sergei-mironov
pushed a commit
to sergei-mironov/tvm
that referenced
this pull request
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add two changes:
So that vision/yolo will have operators from all version of yolov1, yolov2 and yolov3