-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TOPI][DARKNET]Yolo op added #1372
Conversation
please request review from the reviewers |
@zhreshold @srkreddy1238 can you pls review this |
@Huyuwei pls review this |
Is yolo op particularly for yolov3? @PariksheetPinjari909 |
@zhreshold Yes, Yolo op is used only in yolov3. |
topi/python/topi/vision/yolo/yolo.py
Outdated
# pylint: disable=invalid-name, unused-variable | ||
""" | ||
YOLO Operator | ||
==================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not exceed the text length above .
@PariksheetPinjari909 please fix according to @srkreddy1238 's comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tqchen Review comments fixed. Pls check |
Thanks @PariksheetPinjari909 for the contribution. Thanks @srkreddy1238 and @zhreshold for helpful reviews, this is now merged! |
This PR add two changes:
So that vision/yolo will have operators from all version of yolov1, yolov2 and yolov3