Fix conda package builds #1445
Merged
Fix conda package builds #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently a test failed because of wrong results, but my changes should not affect any of the actual compute code, so I'm baffled. |
…libs package. This still needs some fixes for nnvm since it does not search the standard install paths for libraries.
|
Wait, I noticed that it says I've updated the refs on some of the submodules, but I never did that explicitly. I'll reset them to the state in master. |
tqchen
approved these changes
Jul 17, 2018
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Aug 4, 2018
sergei-mironov
pushed a commit
to sergei-mironov/tvm
that referenced
this pull request
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conda packages were in bad shape and some of them stopped working (in part due to the merging of tvm and nnvm).
I spent a bit of time cleaning up and modernizing the build. The packages should build without issues on mac and linux (although you need a bit of special setup on mac because the conda compiler packages require that).
On major change is that the package no longer build with cuda enabled, but that can be fixed later.
One thing that could be helpful to keep them working in the future would be to make the conda build a part of the CI pipeline, but I haven't gone into that.