[CODEGEN][SDACCEL] add support for specifying FPGA device name #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishi-t
reviewed
Jul 18, 2018
| @@ -40,6 +40,8 @@ def check_device(device, host="llvm"): | |||
| b.asnumpy(), np.exp(a.asnumpy()), rtol=1e-5) | |||
|
|
|||
| check_device("sdaccel") | |||
There was a problem hiding this comment.
In the case which XCL_PLATFORM is not set and AWS_PLATFORM is set, dose the above check_device do same test of the following check_device? It may not occur problem but I leave the comment ;)
There was a problem hiding this comment.
Oh, sorry. On second thought, this may be needed for the test of fallback if not specified device. never mind my comment. Looks good to me.
nishi-t
approved these changes
Jul 18, 2018
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Aug 4, 2018
sergei-mironov
pushed a commit
to sergei-mironov/tvm
that referenced
this pull request
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to specify the FPGA device name with a target option.