[AUTOTVM] Misc bug fix #1467
Merged
[AUTOTVM] Misc bug fix #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
merrymercy
commented
Jul 21, 2018
•
merrymercy
commented
- fix bugs on using history data in xgboost model
- fix bugs on tuning record
- add early stopping in tuner
- other
|
@eqy can you help review this? |
eqy
reviewed
Jul 21, 2018
| if not kwargs.get('use_ndk', False): | ||
| file_name = "tmp_func_%0x.tar" % getrandbits(64) |
There was a problem hiding this comment.
We no longer need the filename randomization that we had before? I wonder if this will still be useful if remote sessions are reused and overwritten files are not handled properly (e.g., Android).
eqy
reviewed
Jul 21, 2018
| @@ -1,5 +1,5 @@ | |||
| """ | |||
| How to get high performance convolution kernel on NVIDIA GPU by auto-tuning | |||
| Tuning high performance convolution kernel on NVIDIA GPU | |||
There was a problem hiding this comment.
Can be reduced to just "Tuning High Performance Convolution on NVIDIA GPUs"
tqchen
approved these changes
Jul 21, 2018
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Aug 4, 2018
sergei-mironov
pushed a commit
to sergei-mironov/tvm
that referenced
this pull request
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.