Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unity]Lazy transform param now only work on non-dataflow block #14864

Merged
merged 1 commit into from
May 17, 2023

Conversation

jinhongyii
Copy link
Contributor

As #14829 mentioned, set_item is an impure function, so LazyTransformParam Pass should be done after manually applyiyng ToNonDataflow pass. This PR corrects the behavior.

cc: @slyubomirsky

@tvm-bot
Copy link
Collaborator

tvm-bot commented May 16, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@jinhongyii
Copy link
Contributor Author

@tqchen

@slyubomirsky
Copy link
Contributor

Thank you for making the change :)

@slyubomirsky slyubomirsky mentioned this pull request May 18, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants