Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NNVM][TENSORFLOW]Local Response Normalization added for tensorflow #1522

Merged
merged 2 commits into from
Aug 2, 2018

Conversation

siju-samuel
Copy link
Member

LRN Operator added for tensorflow.
@srkreddy1238 Could you please review this changes. Thanks.

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from others in the community.

@@ -468,6 +468,20 @@ def _impl(inputs, attr, params):
ignores=['index_type', 'T'])(new_inputs, attr)
return _impl

def _lrn():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siju-samuel
I see few default params in tensorflow for LRN.

Please handle them here.

Copy link
Contributor

@srkreddy1238 srkreddy1238 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @siju-samuel

LGTM.

@tqchen tqchen merged commit 2875a12 into apache:master Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants