Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unity]: fix error on enum #15451

Merged
merged 2 commits into from
Aug 1, 2023
Merged

[Unity]: fix error on enum #15451

merged 2 commits into from
Aug 1, 2023

Conversation

Lantianyou
Copy link
Contributor

No description provided.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Aug 1, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@Lantianyou Lantianyou changed the title feat(web): fix error on enum [Unity]: fix error on enum Aug 1, 2023
@Lantianyou
Copy link
Contributor Author

Hi @tqchen . Thank you for reviewing my PR. As I am reading the code on web, I found the typescript and eslint configuration can be significantly improved.
I assume the liner and type checker under web directory is not working for other developers as well, because some of non-recommended code style shows up. like ==. It is best to use === in JavaScript. Those code can run, but the best paractice is to avoid them.

@Lantianyou
Copy link
Contributor Author

Lantianyou commented Aug 1, 2023

I will submit a PR #15452 fix the eslint and typescript config and fixes suggested by them to improve the DX and reliability of the current code.

Would you mind reviewing it then? Thanks in advance.

@tqchen
Copy link
Member

tqchen commented Aug 1, 2023

Thank you @Lantianyou for the PRs , yes they are really appreciated

@tqchen tqchen merged commit ef00a96 into apache:unity Aug 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants