Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Relax][UnitTest] Validate IRModule with multiple targets #16960

Merged
merged 1 commit into from
May 24, 2024
Merged

[Relax][UnitTest] Validate IRModule with multiple targets #16960

merged 1 commit into from
May 24, 2024

Conversation

Lunderberg
Copy link
Contributor

This commit adds a unit test to verify that a single IRModule can contain functions that will be used on multiple distinct targets. Previously, this test case caused errors when running the LegalizeOps and ApplyDefaultSchedule transforms.

@Lunderberg Lunderberg marked this pull request as draft April 30, 2024 18:44
@Lunderberg
Copy link
Contributor Author

This PR adds a unit test validating an end-to-end compilation. On main, this end-to-end test encounters the errors resolved in PRs #16958 and #16959.

This current PR branch includes these two fixes, and is marked as a draft until the bugfix PRs land.

@Lunderberg
[Relax][UnitTest] Validate IRModule with multiple targets
cf021a1 
This commit adds a unit test to verify that a single `IRModule` can
contain functions that will be used on multiple distinct targets.
Previously, this test case caused errors when running the
`LegalizeOps` and `ApplyDefaultSchedule` transforms.
@Lunderberg Lunderberg force-pushed the relax_ir_module_with_multiple_targets branch from 8684163 to cf021a1 Compare May 15, 2024 13:21
@Lunderberg Lunderberg marked this pull request as ready for review May 15, 2024 13:21
@Lunderberg
Copy link
Contributor Author

This PR is now rebased on top of the prerequisite PRs #16958 and #16959, and is ready for review. It does not add any functionality in itself, but adds a test to validate expected behavior for compilation of a Relax IRModule containing multiple targets.

@tqchen tqchen merged commit cf2753e into apache:main May 24, 2024
19 of 20 checks passed
@Lunderberg Lunderberg deleted the relax_ir_module_with_multiple_targets branch May 24, 2024 14:45
@ysh329 ysh329 mentioned this pull request Jul 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tqchen tqchen tqchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lunderberg @tqchen