[Relax][Bugfix] Apply FuseOps to nested DataflowBlock #17022
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it is ill-formed for control-flow to occur within a `DataflowBlock`, it is legal for a `DataflowBlock` to be contained within a control-flow. Prior to this commit, the `FuseOps` and `FuseOpsByPattern` transforms erroneously skipped `DataflowBlock` instances that were contained within a `relax::If` node. This commit updates `FuseOps` to apply operator fusion to any dataflow block, regardless of whether it is found at the top level of a a Relax function. Co-authored-by: Chris Sullivan <csullivan@octoml.ai>
tqchen
requested changes
May 24, 2024
| @@ -262,16 +262,11 @@ class GraphCreator : public ExprVisitor { | |||
| IndexedForwardGraph::Node* leaf_node = nullptr; | |||
| if (it != graph_.node_map.end()) { | |||
| leaf_node = it->second; | |||
| } else if (leaf_expr->IsInstance<ConstantNode>() || leaf_expr->IsInstance<ShapeExprNode>() || | |||
| leaf_expr->IsInstance<PrimValueNode>() || leaf_expr->IsInstance<StringImmNode>() || | |||
There was a problem hiding this comment.
Is this intended change? Seems that we should consider sass where constant value(and there may not be a binding pt)
|
Closing to resubmit as a new PR (same issue as mentioned here), due to CI issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is ill-formed for control-flow to occur within a
DataflowBlock, it is legal for aDataflowBlockto be contained within a control-flow. Prior to this commit, theFuseOpsandFuseOpsByPatterntransforms erroneously skippedDataflowBlockinstances that were contained within arelax::Ifnode.This commit updates
FuseOpsto apply operator fusion to any dataflow block, regardless of whether it is found at the top level of a a Relax function.