Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TOPI] Add dense schedule for fp16 and fp32 using gemm #17091

Merged
merged 15 commits into from
Jul 9, 2024
Merged

[TOPI] Add dense schedule for fp16 and fp32 using gemm #17091

merged 15 commits into from
Jul 9, 2024

Conversation

eirenevp
Copy link
Contributor

Add a new schedule for the dense operator
based on the gemm algorithm.

@eirenevp
[TOPI] Add dense schedule for fp16 and fp32 using gemm
b2ac3ab 
Add a new schedule for the dense operator
based on the gemm algorithm.

Change-Id: Iaf4423d21d20b5813c77a0a27c4751f8cbd1d8b8
@ekalda
Copy link
Contributor

ekalda commented Jun 13, 2024

cc @Anndrey24 @lhutton1 @leandron

@eirenevp
[TOPI] Restore topi x86 dense file
8c74c3c 
Change-Id: I545a805f40197db01d91ce622a890754d4a3b901
@eirenevp
[lint] Ignore unused args and disable mypy type checking
6eea7a6 
Change-Id: Ica02890f132b67e3c9bd64f3fb98ee8c060e8c05
Anndrey24
Anndrey24 reviewed Jun 14, 2024
View reviewed changes
Copy link
Contributor

@Anndrey24 Anndrey24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, @eirenevp ! It's great to finally have an arm_cpu-specific dense schedule which we could possibly extend to also generate SVE instructions in the future.
I've just left a few comments based on my experience with the conv2d schedule.

cmake/config.cmake Outdated Show resolved Hide resolved
python/tvm/relay/op/strategy/arm_cpu.py Outdated Show resolved Hide resolved
python/tvm/relay/op/strategy/arm_cpu.py Outdated Show resolved Hide resolved
python/tvm/topi/arm_cpu/dense_alter_op.py Outdated Show resolved Hide resolved
python/tvm/topi/arm_cpu/dense_gemm.py Outdated Show resolved Hide resolved
python/tvm/topi/arm_cpu/dense_gemm.py Outdated Show resolved Hide resolved
tests/python/relay/test_dense.py Outdated Show resolved Hide resolved
tests/python/relay/test_dense.py Outdated Show resolved Hide resolved
tests/python/relay/test_dense.py Outdated Show resolved Hide resolved
python/tvm/topi/arm_cpu/dense_gemm.py Outdated Show resolved Hide resolved
@eirenevp
[TOPI] Update dense shedule files
17bfe7c 
Change-Id: I11126864bdcfec1c88dbc39bafa18c8b78bbe5fc
@eirenevp
[lint] Disable invalid names
0362f62 
Change-Id: Ibbcfa2a94d14c9013e231c95725b0f651ae4ff46
@eirenevp
[TOPI] Change tol depending on dtpye for test dense
9eda309 
Change-Id: Iaefc79b7c415d4cdca2917b5c5fa5842eba2f71d
@eirenevp
[TOPI] Run dense gemm test only on aarch64
eefb274 
Change-Id: Ia6468fe6cf113781819c871e1f110bf4e98a3d59
@eirenevp
[lint] Lint test dense file
c6ca352 
Change-Id: I3e5c532ed041c691237bf04fda4645bf25befbcc
@eirenevp
[TOPI] Update dense_alter_op to work with relay.traspose
a60717b 
Change-Id: I1217eaec3b63eccfa32bcbf3b410f09fa0997f36
@eirenevp
[TOPI] Update test_select_implementation
0f8aa94 
Change-Id: Iccd59c8afdd70a98da031ff2d0cf8f5d3378a700
@eirenevp
[TOPI] Fix test_select_implementationfor dense_gemm.arm_cpu
078988d 
Change-Id: I8851b227a9dacf90046e4d3d1b0418355145e79a
@eirenevp
[TOPI] Remove topi test for arm cpu dense
0822244 
Change-Id: Ib50606a829142202142b326a111580f9eec72f8c
@eirenevp
[TOPI] Run keras test with level 3 opt
f6d7a17 
Change-Id: I44bf4bfbf85b5ab4fa91d653af25ae22f01ed79a
@eirenevp
[TOPI] Disable test any dense for aarch64
6f5fb0f 
Change-Id: Ie85f7d5c6d0e99fc389bd9b3f29787065e1e0cd0
@eirenevp
[lint] tests/python/relay/test_any.py
e0b544a 
Change-Id: I170e09358b61217586adc3591c020b065e2f5d3e
ekalda
ekalda approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@ekalda ekalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all the work on this @eirenevp!

@ekalda ekalda merged commit c4e6f96 into apache:main Jul 9, 2024
19 checks passed
@ysh329 ysh329 mentioned this pull request Jul 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhutton1 lhutton1 lhutton1 left review comments

@Anndrey24 Anndrey24 Anndrey24 left review comments

@ekalda ekalda ekalda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eirenevp @ekalda @Anndrey24 @lhutton1