[FFI] Improve error messages when array/map types do not match in function calls #7330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
requested changes
Jan 24, 2021
tqchen
requested changes
Jan 24, 2021
tqchen
changed the title
junrushao
reviewed
Jan 24, 2021
junrushao
reviewed
Jan 24, 2021
junrushao
reviewed
Jan 24, 2021
|
The improvement is super helpful! Thanks! |
|
I've addressed all the review comments. I totally missed |
junrushao
reviewed
Jan 25, 2021
tkonolige
force-pushed
the
array_type_print_v2
branch
from
1e9f3c5
to
4597770
Compare
|
I think this PR is good to merge once the CI is green |
tkonolige
force-pushed
the
array_type_print_v2
branch
2 times, most recently
from
77e943a
to
75f3a0e
Compare
…ective classes are defined so they will always be found correctly
tkonolige
force-pushed
the
array_type_print_v2
branch
from
75f3a0e
to
8830022
Compare
|
@tqchen @junrushao1994 CI is green for this PR now. |
junrushao
approved these changes
Feb 2, 2021
There was a problem hiding this comment.
Thank you @tkonolige for helping improve the error reporting :-)
|
@tqchen Please take another look and approve explicitly if there is no further issue. I can merge it in only with all reviewers' approval :-) |
tqchen
approved these changes
Feb 2, 2021
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 11, 2021
…ction calls (apache#7330) * [FIX] Improve error messages when array/map types do not match in function calls * missed some places for renaming * Rename Mismatch to CheckAndGetMismatch. Add Check back in. Use Optional::defined. * Optional<String> -> String * formatting * move ObjectTypeChecker template specializations into where thier respective classes are defined so they will always be found correctly
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
…ction calls (apache#7330) * [FIX] Improve error messages when array/map types do not match in function calls * missed some places for renaming * Rename Mismatch to CheckAndGetMismatch. Add Check back in. Use Optional::defined. * Optional<String> -> String * formatting * move ObjectTypeChecker template specializations into where thier respective classes are defined so they will always be found correctly
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
…ction calls (apache#7330) * [FIX] Improve error messages when array/map types do not match in function calls * missed some places for renaming * Rename Mismatch to CheckAndGetMismatch. Add Check back in. Use Optional::defined. * Optional<String> -> String * formatting * move ObjectTypeChecker template specializations into where thier respective classes are defined so they will always be found correctly
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
…ction calls (apache#7330) * [FIX] Improve error messages when array/map types do not match in function calls * missed some places for renaming * Rename Mismatch to CheckAndGetMismatch. Add Check back in. Use Optional::defined. * Optional<String> -> String * formatting * move ObjectTypeChecker template specializations into where thier respective classes are defined so they will always be found correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes error messages that arise when a runtime array does not have the correct element types for a function. For example:
Note that because runtime
Arrays are not homogenous, specific elements can fail the type checking. I've added which element fails to the errors message along with its type. This can also happen forMaps, but I could not figure out a good way to print which element mismatches (because the elements are unordered and I worry printing the key may take too much space).This is a replacement for #7309 that returns the mismatched type when a runtime object cannot be converted.
@jroesch @tqchen @junrushao1994 @rkimball