-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing round(), floor(), ceil() for target C lowering #7382
Conversation
LGTM, thanks! @areusch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! a much needed one :).
one suggestion and I think it would better if we can have some test cases in tests/python/unittest/test_target_codegen_c_host.py to cover these.
thanks @cbalint13! this looks good but would be great if you could write a test case to prevent regressions in the future. I think the |
@mdw-octoml , @areusch , @manupa-arm
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @cbalint13 @manupa-arm @mdw-octoml @areusch |
round
operations:@jroesch @masashi @mdw-octoml Please help me review.
Thank you !