fix duplicated symbol bug in external codegen #7383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 11, 2021
Co-authored-by: 袁航剑 <yuanhangjian@bytedance.com>
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
Co-authored-by: 袁航剑 <yuanhangjian@bytedance.com>
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
Co-authored-by: 袁航剑 <yuanhangjian@bytedance.com>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
Co-authored-by: 袁航剑 <yuanhangjian@bytedance.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the original purpose of the code is that the same symbol_name can only be registered once for each external codegen。
but the actual result is that the name of symbol_name can’t be same with code_gen_name, for example, we can’t set global_symbol name with “ccompiler” for relay.ext.ccompiler.
and the code logic is error, because cached_symbol.count(sn) is always 0, so the if sentence is always false。
cc @zhiics