Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docker][ROCm] Add minimal ROCm docker #7422

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Conversation

jtuyls
Copy link
Contributor

@jtuyls jtuyls commented Feb 8, 2021

This PR adds a minimal docker for using TVM with ROCm.

@adityaatluri @leandron , could you please help with reviewing this PR

Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just would like a bit of context on the motivation - is this going to be mentioned in a tutorial and it claims to be a Demo docker for ROCm?

@jtuyls
Copy link
Contributor Author

jtuyls commented Feb 10, 2021

@leandron The motivation is that I have been trying out TVM with ROCm and it took me a bit of time to put the necessary pieces together so I think this improves usability and might allow users to get started more quickly. Next to this, I also think it would be useful to have a tutorial on using TVM with ROCm as there isn't too much material on that.

@leandron
Copy link
Contributor

Yeah, fair enough. I guess we can merge this @tqchen, maybe?

@masahi masahi merged commit d769727 into apache:main Feb 12, 2021
@masahi
Copy link
Member

masahi commented Feb 12, 2021

Thanks @jtuyls @leandron

Lokiiiiii pushed a commit to Lokiiiiii/tvm that referenced this pull request Mar 2, 2021
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants