Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Relay][Op][Bug] Fix missing return in scatter_nd cuda strategy #7447

Merged
merged 2 commits into from
Feb 12, 2021
Merged

[Relay][Op][Bug] Fix missing return in scatter_nd cuda strategy #7447

merged 2 commits into from
Feb 12, 2021

Conversation

altanh
Copy link
Contributor

@altanh altanh commented Feb 11, 2021

tmoreau89
tmoreau89 reviewed Feb 11, 2021
View reviewed changes
Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @altanh, could you add a test that would have failed before?

tmoreau89
tmoreau89 approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@masahi masahi merged commit b36bdf6 into apache:main Feb 12, 2021
Lokiiiiii pushed a commit to Lokiiiiii/tvm that referenced this pull request Mar 2, 2021
@altanh @Lokiiiiii
[Relay][Op][Bug] Fix missing return in scatter_nd cuda strategy (apac…
f61325b 
…he#7447)

* fix missing return in scatter_nd cuda strategy

* add Relay test for scatter_nd, fix documentation
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2021
@altanh @trevor-m
[Relay][Op][Bug] Fix missing return in scatter_nd cuda strategy (apac…
d89af0a 
…he#7447)

* fix missing return in scatter_nd cuda strategy

* add Relay test for scatter_nd, fix documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrookhart mbrookhart mbrookhart approved these changes

@tmoreau89 tmoreau89 tmoreau89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@altanh @mbrookhart @tmoreau89 @masahi