[Bugfix][Relay] Crash in match_exhaustion.cc when given an empty tuple pattern or constructor with no args #7459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
…e pattern or constructor with no args (apache#7459) * [match_exhaustion] Fix cartesian product to handle empty tuple patterns or constructors with no args * Test cases do not actually exhibit the fixed bug * Mistake in comment
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
…e pattern or constructor with no args (apache#7459) * [match_exhaustion] Fix cartesian product to handle empty tuple patterns or constructors with no args * Test cases do not actually exhibit the fixed bug * Mistake in comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two test cases that previously caused match exhaustion to crash due to a bad decision in implementing
CartesianProduct. These cases happen when an empty tuple or constructor with no fields (e.g.,Nil()) needs to be expanded -- the Cartesian product used for wildcard expansion assumed that it would have at least one field to expand. This was silly of me, since there is exactly one expansion of zero fields:{∅}.I added a base case to
CartesianProductand regression tests.Please review @MarisaKirisame @jroesch. (Test case found through fuzzing.)