Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[µTVM] Rev ci-qemu to 0.02 (Introduce onnx python dependency) #7728

Merged
merged 2 commits into from
Mar 24, 2021

Conversation

areusch
Copy link
Contributor

@areusch areusch commented Mar 23, 2021

This PR unblocks #7557 by adding onnx to the python packages usable in ci-qemu.

Also as part of rebuilding the container, change the method by which we install kitware apt keys to make it more portable.

@tmoreau89 @mdw-octoml

Copy link
Contributor

@mdw-octoml mdw-octoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but see comment

@@ -64,3 +64,7 @@ RUN bash /install/ubuntu_install_qemu.sh
COPY install/ubuntu_install_zephyr.sh /install/ubuntu_install_zephyr.sh
RUN bash /install/ubuntu_install_zephyr.sh
ENV ZEPHYR_BASE=/opt/zephyrproject/zephyr

# Install ONNX
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this is needed. Why not just install the ONNX pip package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must reduce variation in ci-* images :)

Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @areusch , LGTM

@tmoreau89 tmoreau89 merged commit 63d8e97 into apache:main Mar 24, 2021
@tmoreau89
Copy link
Contributor

Thanks @mdw-octoml @areusch the PR has been merged

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
…#7728)

* Fix ci-qemu build, add ONNX

* rev ci-qemu to staging
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request May 11, 2021
…#7728)

* Fix ci-qemu build, add ONNX

* rev ci-qemu to staging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants