-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[µTVM] Rev ci-qemu to 0.02 (Introduce onnx python dependency) #7728
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but see comment
@@ -64,3 +64,7 @@ RUN bash /install/ubuntu_install_qemu.sh | |||
COPY install/ubuntu_install_zephyr.sh /install/ubuntu_install_zephyr.sh | |||
RUN bash /install/ubuntu_install_zephyr.sh | |||
ENV ZEPHYR_BASE=/opt/zephyrproject/zephyr | |||
|
|||
# Install ONNX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised this is needed. Why not just install the ONNX pip package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
must reduce variation in ci-* images :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @areusch , LGTM
Thanks @mdw-octoml @areusch the PR has been merged |
…#7728) * Fix ci-qemu build, add ONNX * rev ci-qemu to staging
…#7728) * Fix ci-qemu build, add ONNX * rev ci-qemu to staging
This PR unblocks #7557 by adding
onnx
to the python packages usable in ci-qemu.Also as part of rebuilding the container, change the method by which we install kitware apt keys to make it more portable.
@tmoreau89 @mdw-octoml