-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Prevented docs/1 file from being generated. #8029
Conversation
looks like the correction reveals the doc build errors :) @Lunderberg can you attempt to fix these? |
Sure, I can take a look at the issues. |
ping @Lunderberg to followup on this |
Thanks for the reminder on it! I've fixed about half of the ~80 warnings this afternoon, working my way through the rest. |
ce24ee2
to
728df9f
Compare
The documentation build now passes without warning when I run it locally, so let's see how it goes on the CI. The most frequent issues were broken links/references, missing line breaks in docstrings before code examples, and ambiguous type references in docstrings. |
728df9f
to
0aad04e
Compare
One last minor update, removed some debug code in |
0aad04e
to
124422f
Compare
Next round of updates, tested locally against the newer version of sphinx used by CI, and rebased against main. Should have all build warnings fixed up through commit 1f2ca06 on main. |
124422f
to
ff7f017
Compare
@areusch I think I'll need some help on this one, as the remaining warnings relate to the CI image and setup.
|
@Lunderberg we can try to ignore these two warnings by updating the lines here https://github.com/apache/tvm/blob/main/tests/scripts/task_sphinx_precheck.sh#L41 |
Good point, and I agree that these probably aren't warnings that are relevant for the documentation building. |
Typo in tests/scripts/task_sphinx_precheck.sh caused $TVM_HOME/docs/1 file to be created with stderr output, rather than merged stderr and stdout.
- Previously, several warnings were generated by sphinx, but were unintentionally suppressed. This PR resolves the sphinx warnings.
- Rebased on main and corrected warnings, now up to date as of commit 53e4c60.
- Rebased on main and corrected warnings, now up to date as of commit 1f2ca06.
- Rebased on main and corrected warnings, now up to date as of commit d0791d3.
ff7f017
to
b5a8aa0
Compare
And updated again, both to fix a few more issues that arose on |
And it passed! Should be ready to merge, as it has up-to-date fixes for all documentation warnings on the main branch through yesterday afternoon. |
Thanks @Lunderberg ! |
wow, thanks @Lunderberg for catching this and fixing all the docs bugs! |
* [Docs] Prevented docs/1 file from being generated. Typo in tests/scripts/task_sphinx_precheck.sh caused $TVM_HOME/docs/1 file to be created with stderr output, rather than merged stderr and stdout. * [Docs] Corrected sphinx build warnings - Previously, several warnings were generated by sphinx, but were unintentionally suppressed. This PR resolves the sphinx warnings. * [Docs] Corrected additional sphinx build warnings. - Rebased on main and corrected warnings, now up to date as of commit 53e4c60. * [Docs] Corrected additional sphinx build warnings - Rebased on main and corrected warnings, now up to date as of commit 1f2ca06. * [Docs] Corrected additional sphinx build warnings - Rebased on main and corrected warnings, now up to date as of commit d0791d3. * [Docs] Ignore sphinx warnings from missing "git describe" and sckit-learn versions. Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
* [Docs] Prevented docs/1 file from being generated. Typo in tests/scripts/task_sphinx_precheck.sh caused $TVM_HOME/docs/1 file to be created with stderr output, rather than merged stderr and stdout. * [Docs] Corrected sphinx build warnings - Previously, several warnings were generated by sphinx, but were unintentionally suppressed. This PR resolves the sphinx warnings. * [Docs] Corrected additional sphinx build warnings. - Rebased on main and corrected warnings, now up to date as of commit 53e4c60. * [Docs] Corrected additional sphinx build warnings - Rebased on main and corrected warnings, now up to date as of commit 1f2ca06. * [Docs] Corrected additional sphinx build warnings - Rebased on main and corrected warnings, now up to date as of commit d0791d3. * [Docs] Ignore sphinx warnings from missing "git describe" and sckit-learn versions. Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
Typo in tests/scripts/task_sphinx_precheck.sh caused $TVM_HOME/docs/1
file to be created with stderr output, rather than merged stderr and
stdout.