Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Prevented docs/1 file from being generated. #8029

Merged
merged 6 commits into from
Jun 24, 2021

Conversation

Lunderberg
Copy link
Contributor

Typo in tests/scripts/task_sphinx_precheck.sh caused $TVM_HOME/docs/1
file to be created with stderr output, rather than merged stderr and
stdout.

@tqchen
Copy link
Member

tqchen commented May 13, 2021

looks like the correction reveals the doc build errors :) @Lunderberg can you attempt to fix these?

@Lunderberg
Copy link
Contributor Author

Sure, I can take a look at the issues.

@tqchen
Copy link
Member

tqchen commented Jun 4, 2021

ping @Lunderberg to followup on this

@Lunderberg
Copy link
Contributor Author

Thanks for the reminder on it! I've fixed about half of the ~80 warnings this afternoon, working my way through the rest.

@Lunderberg
Copy link
Contributor Author

The documentation build now passes without warning when I run it locally, so let's see how it goes on the CI. The most frequent issues were broken links/references, missing line breaks in docstrings before code examples, and ambiguous type references in docstrings.

@Lunderberg
Copy link
Contributor Author

One last minor update, removed some debug code in task_sphinx_precheck.sh, but kept a deliberate repeat of the warnings at the end of the precheck script.

@Lunderberg
Copy link
Contributor Author

Next round of updates, tested locally against the newer version of sphinx used by CI, and rebased against main. Should have all build warnings fixed up through commit 1f2ca06 on main.

@Lunderberg
Copy link
Contributor Author

Lunderberg commented Jun 17, 2021

@areusch I think I'll need some help on this one, as the remaining warnings relate to the CI image and setup.

  • WARNING:root:git describe: fatal: No names found, cannot describe anything.

    Cannot reproduce in the local docker image. It looks like sphinx is trying to run git describe, but the CI's copy of the repo is too shallow. How deep of a clone does the CI use?

  • WARNING:root:scikit-learn version 0.24.2 is not supported. Minimum required version: 0.17. Maximum required version: 0.19.2. Disabling scikit-learn conversion API.

    From importing coremltools. The current version 4.1 has a maximum version of scikit-learn<=0.19.2. Unfortunately, the current version of gluoncv==0.10.1 has a minimum version of scikit-learn>=0.23.2, so it won't be a simple update of a single package.

@tqchen
Copy link
Member

tqchen commented Jun 22, 2021

@Lunderberg we can try to ignore these two warnings by updating the lines here https://github.com/apache/tvm/blob/main/tests/scripts/task_sphinx_precheck.sh#L41

@Lunderberg
Copy link
Contributor Author

Good point, and I agree that these probably aren't warnings that are relevant for the documentation building.

Typo in tests/scripts/task_sphinx_precheck.sh caused $TVM_HOME/docs/1
file to be created with stderr output, rather than merged stderr and
stdout.
- Previously, several warnings were generated by sphinx, but were
  unintentionally suppressed.  This PR resolves the sphinx warnings.
- Rebased on main and corrected warnings, now up to date as of commit
  53e4c60.
- Rebased on main and corrected warnings, now up to date as of commit
  1f2ca06.
- Rebased on main and corrected warnings, now up to date as of commit
  d0791d3.
@Lunderberg
Copy link
Contributor Author

And updated again, both to fix a few more issues that arose on main, and to ignore the warnings coming from git describe and coremltools.

@Lunderberg
Copy link
Contributor Author

And it passed! Should be ready to merge, as it has up-to-date fixes for all documentation warnings on the main branch through yesterday afternoon.

@tqchen tqchen merged commit d9fe672 into apache:main Jun 24, 2021
@tqchen
Copy link
Member

tqchen commented Jun 24, 2021

Thanks @Lunderberg !

@Lunderberg Lunderberg deleted the remove_docs_1_file branch June 24, 2021 14:29
@areusch
Copy link
Contributor

areusch commented Jun 25, 2021

wow, thanks @Lunderberg for catching this and fixing all the docs bugs!

ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
* [Docs] Prevented docs/1 file from being generated.

Typo in tests/scripts/task_sphinx_precheck.sh caused $TVM_HOME/docs/1
file to be created with stderr output, rather than merged stderr and
stdout.

* [Docs] Corrected sphinx build warnings

- Previously, several warnings were generated by sphinx, but were
  unintentionally suppressed.  This PR resolves the sphinx warnings.

* [Docs] Corrected additional sphinx build warnings.

- Rebased on main and corrected warnings, now up to date as of commit
  53e4c60.

* [Docs] Corrected additional sphinx build warnings

- Rebased on main and corrected warnings, now up to date as of commit
  1f2ca06.

* [Docs] Corrected additional sphinx build warnings

- Rebased on main and corrected warnings, now up to date as of commit
  d0791d3.

* [Docs] Ignore sphinx warnings from missing "git describe" and sckit-learn versions.

Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Mar 4, 2022
* [Docs] Prevented docs/1 file from being generated.

Typo in tests/scripts/task_sphinx_precheck.sh caused $TVM_HOME/docs/1
file to be created with stderr output, rather than merged stderr and
stdout.

* [Docs] Corrected sphinx build warnings

- Previously, several warnings were generated by sphinx, but were
  unintentionally suppressed.  This PR resolves the sphinx warnings.

* [Docs] Corrected additional sphinx build warnings.

- Rebased on main and corrected warnings, now up to date as of commit
  53e4c60.

* [Docs] Corrected additional sphinx build warnings

- Rebased on main and corrected warnings, now up to date as of commit
  1f2ca06.

* [Docs] Corrected additional sphinx build warnings

- Rebased on main and corrected warnings, now up to date as of commit
  d0791d3.

* [Docs] Ignore sphinx warnings from missing "git describe" and sckit-learn versions.

Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants