[Frontend] Speed up Fold Constant #8208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcf94
requested changes
Jun 8, 2021
|
We use it in dozens of places in the ONNX importer with mod=None, if there was a problem, ~1/3 of the onnx unit tests would have failed. I'm not sure any of the utilities in the frontend/common.py file are actually tested? https://github.com/apache/tvm/blob/main/tests/python/frontend/test_common.py |
jcf94
approved these changes
Jun 9, 2021
masahi
approved these changes
Jun 9, 2021
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 17, 2021
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@masahi
This utiliy was creating a new IRModule from the provided expression if the provided module was None. This isn't strictly necessary, the use cases are correct if we pass in an empty IRModule. The WellFormed check inside IRModule.from_expr was actually taking a lot of the time when importing large ONNX models. This change gets me a 2.6x speedup on importing the large NLP model I'm playing with today.