[Vulkan] Improved error message for extern calls passed to SPIR-V codegen #8332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egen. Previously, the codegen indicated that there was an extern call. Now, also indicate what that extern call is, to aid in debugging.
Lunderberg
force-pushed
the
vulkan_extern_error_message
branch
from
db032bb
to
b9fe385
Compare
|
Potential reviewer: @masahi |
masahi
approved these changes
Jun 26, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
…egen. (apache#8332) Previously, the codegen indicated that there was an extern call. Now, also indicate what that extern call is, to aid in debugging. Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Mar 4, 2022
…egen. (apache#8332) Previously, the codegen indicated that there was an extern call. Now, also indicate what that extern call is, to aid in debugging. Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the codegen indicated that there was an extern call. Now, also indicate what that extern call is, to aid in debugging.