Replace RuntimeError in _lookup_task with deferred error. #8421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows unknown tasks to be created (e.g., when parsing autotvm log files) but not invoked.
|
Hi @junrushao1994 and @jroesch - Mind taking a look? Thanks! |
junrushao
approved these changes
Jul 8, 2021
There was a problem hiding this comment.
Thanks @mdw-octoml for the contribution! The PR looks good to me!
comaniac
approved these changes
Jul 8, 2021
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
|
Thanks @comaniac - applied your suggestion! |
|
Thanks @mdw-octoml @junrushao1994 |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* Replace RuntimeError in _lookup_task with deferred error. This allows unknown tasks to be created (e.g., when parsing autotvm log files) but not invoked. * Format. * Update python/tvm/autotvm/task/task.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> Co-authored-by: Matt Welsh <mdw@mdw.la> Co-authored-by: Cody Yu <comaniac0422@gmail.com>
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Mar 4, 2022
* Replace RuntimeError in _lookup_task with deferred error. This allows unknown tasks to be created (e.g., when parsing autotvm log files) but not invoked. * Format. * Update python/tvm/autotvm/task/task.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> Co-authored-by: Matt Welsh <mdw@mdw.la> Co-authored-by: Cody Yu <comaniac0422@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows unknown tasks to be created (e.g., when parsing autotvm log files) but not invoked.
This change is needed to allow one to read an autotvm log file created by a build of TVM with a different set of registered tasks than the build in which the script reading the log file is using. For example if one has a log file created by a TVM build with CUDA tasks, but reads the log file on a TVM build without CUDA enabled (e.g., running on a different OS without CUDA support).
The change should be safe in the sense that it raises a RuntimeError if the missing task is actually invoked, but the metadata associated with the task can still exist, allowing the log file to be parsed and analyzed.