-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UnitTests][Ethos-N] Mark unit tests as requiring Ethos-N #8873
Conversation
7b6ae98
to
0b7319d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @Lunderberg!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @Lunderberg, I was just curious whether we should have a tvm.testing.contrib
? Personally, I would rather have it as it is here, and it's an improvement either way 😸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM. I remembered we have another test that can be marked with this new decorator, in tvmc
.
0b7319d
to
5c67c0d
Compare
I think I'd lean toward having it here. If some of the tools in contrib require a lot of testing functionality, then I think it would make sense to break it out, but so far it's only been single functions here and there.
Thank you for pointing that out, and I've updated it as well. A quick grep doesn't show any other folders that reference ethosn, so we should be set there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just need to solve the conflicts, and get it past CI.
- Adds the decorator `tvm.testing.requires_ethosn` - Marks all tests in `tests/python/contrib/test_ethosn` as requiring ethosn instead of directly checking `ethosn_available()`. This way, they show up as skipped rather than passing. - Marks test_compile_tflite_module_with_external_codegen as requiring ethosn.
5c67c0d
to
bf765a9
Compare
Sounds good, and merge conflicts are now resolved. |
- Adds the decorator `tvm.testing.requires_ethosn` - Marks all tests in `tests/python/contrib/test_ethosn` as requiring ethosn instead of directly checking `ethosn_available()`. This way, they show up as skipped rather than passing. - Marks test_compile_tflite_module_with_external_codegen as requiring ethosn.
- Adds the decorator `tvm.testing.requires_ethosn` - Marks all tests in `tests/python/contrib/test_ethosn` as requiring ethosn instead of directly checking `ethosn_available()`. This way, they show up as skipped rather than passing. - Marks test_compile_tflite_module_with_external_codegen as requiring ethosn.
Adds the decorator
tvm.testing.requires_ethosn
Marks all tests in
tests/python/contrib/test_ethosn
as requiring ethosn instead of directly checkingethosn_available()
. This way, they show up as skipped rather than passing.