[microTVM] Add method to query template info without creating a project #8950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mehrdadh @areusch , in the context of querying via the Project API the "choices" available on the platforms (zephyr, arduino, etc) - #8940 (comment) |
Add info() method to TemplateProject class so it's possible to query all available options for a given template project without creating a new one. This is necessary because TVMC will query the available options for a given template project to show them to the user so the user can use them to finally create a new project dir. That is also useful in general to query the available options for any project type. For example, one can query all boards available on the Zephyr platform with: import tvm.micro.project as project_api template = project_api.TemplateProject.from_directory(ZEPHYR_TEMPLATE_DIR) boards = template.info()["project_options"][8]["choices"] where 8 element refers to the "zephyr_board" option. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
gromero
force-pushed
the
add-info-method-project-api
branch
from
a5c3008
to
e50b5a8
Compare
areusch
reviewed
Sep 7, 2021
| self._info = self._api_client.server_info_query(__version__) | ||
| if not self._info["is_template"]: | ||
| raise NotATemplateProjectError() | ||
|
|
||
| def generate_project(self, graph_executor_factory, project_dir): | ||
| def generate_project(self, graph_executor_factory, project_dir, options): |
There was a problem hiding this comment.
just noting for posterity that originally i didn't do this because i wanted all calls to Project API server to use the same options, but since there is just one call used with TemplateProject, and you might actually want to examine self._info before constructing options, this makes more sense to me
There was a problem hiding this comment.
I see your point and that was exactly what I thought when I was going for that change. Thanks your comment, it really helps me to understand the design better and increases my confidence that I'm following the motivations behind it correctly :)
areusch
approved these changes
Sep 7, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
…ct (apache#8950) Add info() method to TemplateProject class so it's possible to query all available options for a given template project without creating a new one. This is necessary because TVMC will query the available options for a given template project to show them to the user so the user can use them to finally create a new project dir. That is also useful in general to query the available options for any project type. For example, one can query all boards available on the Zephyr platform with: import tvm.micro.project as project_api template = project_api.TemplateProject.from_directory(ZEPHYR_TEMPLATE_DIR) boards = template.info()["project_options"][8]["choices"] where 8 element refers to the "zephyr_board" option. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…ct (apache#8950) Add info() method to TemplateProject class so it's possible to query all available options for a given template project without creating a new one. This is necessary because TVMC will query the available options for a given template project to show them to the user so the user can use them to finally create a new project dir. That is also useful in general to query the available options for any project type. For example, one can query all boards available on the Zephyr platform with: import tvm.micro.project as project_api template = project_api.TemplateProject.from_directory(ZEPHYR_TEMPLATE_DIR) boards = template.info()["project_options"][8]["choices"] where 8 element refers to the "zephyr_board" option. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add info() method to TemplateProject class so it's possible to query all
available options for a given template project without creating a new
one. This is necessary because TVMC will query the available options for
a given template project to show them to the user so the user can use
them to finally create a new project dir.
That is also useful in general to query the available options for any
project type. For example, one can query all boards available on the
Zephyr platform with:
import tvm.micro.project as project_api
template = project_api.TemplateProject.from_directory(ZEPHYR_TEMPLATE_DIR)
boards = template.info()["project_options"][8]["choices"]
where 8 is refers to the "zephyr_board" option.
Signed-off-by: Gustavo Romero gustavo.romero@linaro.org