[Relay, Tests] Make expressions in the DynamicToStatic pass tests more dynamic #8989
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While experimenting with
dyn.strided_slice
I noticed that some of the DynamicToStatic pass tests are not testing dynamic expressions. For example, the created strided_slice function heretvm/tests/python/relay/test_pass_dynamic_to_static.py
Line 435 in 02f885a
looks like this:
which I think doesn't test the DynamicToStatic pass being executed on this expression. With the small changes in this PR, the above function looks like this:
which I think is a better test for the DynamicToStatic pass.
Similarly, tests for topk, resize2d, upsampling, upsampling3d and pad have been adjusted.
@mbrookhart Could you help with reviewing this PR?