Support colons in input-shapes tvmc command line arguments
#9080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binarybana
requested review from
areusch,
comaniac,
jroesch,
junrushao,
jwfromm,
leandron,
merrymercy,
tqchen and
yzhliu
as code owners
|
Hi @binarybana, the changes you've pushed don't seem related to the changes you describe, could you take another look that this PR? 😸 |
binarybana
changed the title
input-shapes tvmc command line arguments
|
Apologies for that! Got sloppy with |
mbrookhart
approved these changes
Sep 23, 2021
leandron
approved these changes
Sep 23, 2021
Mousius
approved these changes
Sep 23, 2021
|
Merged now, thanks @Mousius @binarybana @mbrookhart! |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support colons in input names passed into
input-shapestvmccommand line arguments. Ideally we'd simplify the format so that it's not a complicated regex, but wanted to address an issue that I ran into in the wild.