-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Topi] Fix direct SIMD conv2d schedule name #9225
Conversation
cc @areusch , @sergey-grovety |
2e4c972
to
3484d95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mehrdadh let's merge this, i think this is a step in the right direction; however, i think we should actually further rename this. i'm not settled yet on what the new name should be. some thoughts:
direct_simd
should probably just become something likesmlad
micro_dev
should probably become arm_cpu_v8m or something along those lines.
though we purport to match on the ISA associated with -mcpu
, we don't do this very aggressively yet. and, i'm not sure if we have a pattern in schedule names in here to distinguish between various ISA.
cc @u99127 @manupa-arm @Mousius if you guys have ideas on ways you'd like to organize arm_cpu schedules between Cortex-A and Cortex-M
also it's worth pointing out that we would avoid merging incremental name cleanups in the future (as this would invalidate autotuning logs), but since Cortex-M autotuning is still getting off the ground I think it's ok this time. |
@areusch I agree that we should come up with a naming system at least for microTVM at the moment if not possible for all schedules. I suggest we settle down on something before merging #9233. |
* feature tested * change name
* feature tested * change name
* feature tested * change name
This PR rename schedule name by adding input layout to it.