Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Topi] Fix direct SIMD conv2d schedule name #9225

Merged
merged 3 commits into from
Oct 13, 2021

Conversation

mehrdadh
Copy link
Member

@mehrdadh mehrdadh commented Oct 7, 2021

This PR rename schedule name by adding input layout to it.

@mehrdadh
Copy link
Member Author

mehrdadh commented Oct 7, 2021

cc @areusch , @sergey-grovety

Copy link
Contributor

@areusch areusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mehrdadh let's merge this, i think this is a step in the right direction; however, i think we should actually further rename this. i'm not settled yet on what the new name should be. some thoughts:

  • direct_simd should probably just become something like smlad
  • micro_dev should probably become arm_cpu_v8m or something along those lines.

though we purport to match on the ISA associated with -mcpu, we don't do this very aggressively yet. and, i'm not sure if we have a pattern in schedule names in here to distinguish between various ISA.

cc @u99127 @manupa-arm @Mousius if you guys have ideas on ways you'd like to organize arm_cpu schedules between Cortex-A and Cortex-M

@areusch
Copy link
Contributor

areusch commented Oct 13, 2021

also it's worth pointing out that we would avoid merging incremental name cleanups in the future (as this would invalidate autotuning logs), but since Cortex-M autotuning is still getting off the ground I think it's ok this time.

@areusch areusch merged commit 185e2fb into apache:main Oct 13, 2021
@mehrdadh mehrdadh deleted the fix_schedule_name branch October 13, 2021 16:14
@mehrdadh
Copy link
Member Author

@areusch I agree that we should come up with a naming system at least for microTVM at the moment if not possible for all schedules. I suggest we settle down on something before merging #9233.
I prefer something related to ISA and if it is only for certain ARM cores, I suggest to add something to indicate that.

masahi pushed a commit to Laurawly/tvm-1 that referenced this pull request Oct 14, 2021
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants