[Profiler] Sort columns in table and csv output #9300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkonolige
requested review from
areusch,
junrushao,
kazum,
liangfu,
masahi,
tmoreau89,
tqchen,
vinx13 and
ZihengJiang
as code owners
This should fix some problems around flakey profiler tests based on order of columns.
tkonolige
force-pushed
the
profiler_sorted_cols
branch
from
8b21254
to
afed35d
Compare
Lunderberg
reviewed
Oct 15, 2021
| for (auto header : unique_headers) { | ||
| if (header != "Name" && header != "Duration (us)" && header != "Percent") { | ||
| if (std::find(headers.begin(), headers.end(), header) == headers.end()) { |
There was a problem hiding this comment.
Are we worried about this being quadratic in the number of unique headers, or will there always be a small number?
There was a problem hiding this comment.
I would assume the number of headers is going to be small.
There was a problem hiding this comment.
Agreed, I just wasn't sure if there were other edge cases. In that case, looks good to me.
masahi
approved these changes
Oct 16, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
This should fix some problems around flakey profiler tests based on order of columns.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
This should fix some problems around flakey profiler tests based on order of columns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix some problems around flakey profiler tests based on order of columns. See #9275
@Lunderberg