This repository has been archived by the owner on May 12, 2021. It is now read-only.
(TWILL-223) Make FileContextLocationFactory UGI aware #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chtyim
commented
Mar 28, 2017
chtyim
commented
- Use different FileContext object based on the caller UGI
- Allows sharing the same factory instance for different user
chtyim
force-pushed
the
feature/TWILL-223
branch
from
3472cf5
to
36befea
Compare
albertshau
reviewed
Mar 29, 2017
| CommonConfigurationKeysPublic.FS_DEFAULT_NAME_DEFAULT); | ||
| throw new IllegalStateException("File system with URI '" + defaultURI + "' is not supported", cause); | ||
| } | ||
| throw new RuntimeException(cause); |
There was a problem hiding this comment.
at this point the cause should be a RuntimeException right? in which case we should just propagate it directly rather than wrapping it.
There was a problem hiding this comment.
Well, it can be Exception or RuntimeException. I can add a check to just throw the cause without wrapping if the type is RuntimeException
- Use different FileContext object based on the caller UGI - Allows sharing the same factory instance for different user
chtyim
force-pushed
the
feature/TWILL-223
branch
from
36befea
to
2c8d9e8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.