This repository has been archived by the owner on May 12, 2021. It is now read-only.
(TWILL-260) Upgrade version of zkclient - library that kafka is using. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- current version of zkclient (0.3) that kafka_2.10 version 0.8.0 is using is buggy it does not handle well sasl authenticate and connected events fix was done in zkclient 0.7 - instead of more invasive change of upgrading kafka (API changes) zkclient upgrade should be rather painless and fix issues with inability to connect when sasl is enabled especially with fast network that creates race condition between sasl authentication and connected zk events
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it does not handle well sasl authenticate and connected events
fix was done in zkclient 0.7
zkclient upgrade should be rather painless and fix issues with inability to connect when sasl is enabled
especially with fast network that creates race condition between sasl authentication and connected zk events