This repository has been archived by the owner on May 12, 2021. It is now read-only.
(TWILL-265) Upgrading kafka version and removing lz4 dependency #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CuriousVini
force-pushed
the
TWILL-265-lz4-dep
branch
from
d0c85fe
to
bb0c64a
Compare
chtyim
approved these changes
Jan 15, 2020
CuriousVini
force-pushed
the
TWILL-265-lz4-dep
branch
9 times, most recently
from
03f4dd6
to
67d9ffe
Compare
CuriousVini
force-pushed
the
TWILL-265-lz4-dep
branch
from
67d9ffe
to
2b019e5
Compare
chtyim
reviewed
Jan 17, 2020
| @@ -135,6 +135,9 @@ public void finished() { | |||
| server = new EmbeddedKafkaServer(kafkaServerConfig); | |||
| server.startAndWait(); | |||
|
|
|||
| // Wait a little while to make sure changes is reflected in broker service | |||
| TimeUnit.SECONDS.sleep(3); | |||
There was a problem hiding this comment.
It is probably worth to expose the BrokerService from the KafkaClient and you can have a more efficient wait by use the BrokerService.addChangeListener method or simply poll from the BrokerService.getBrokerList() method.
There was a problem hiding this comment.
I kept it same as testBrokerChange(). But I agree the suggested approach would be a little bit more efficient implementation.
I will open another pr with that enhancement to both the tests to keep the changes in this pr related to kafka version upgrade.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.