Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #379: Clean up code #380

Merged
merged 15 commits into from
Sep 4, 2024
Merged

Issue #379: Clean up code #380

merged 15 commits into from
Sep 4, 2024

Conversation

reckart
Copy link
Member

@reckart reckart commented Aug 19, 2024

What's in the PR

  • Cleaning up...

How to test manually

  • No specific test procedure

Automatic testing

  • PR adds/updates unit tests

Documentation

  • PR adds/updates documentation

Organizational

  • PR adds/updates dependencies.
    Only dependencies under approved licenses are allowed. LICENSE and NOTICE files in the respective modules where dependencies have been added as well as in the project root have been updated.

- Cleaning up...
@reckart reckart added the ⚙️ Refactoring Improvement for development or maintainability label Aug 19, 2024
@reckart reckart added this to the 3.6.0 milestone Aug 19, 2024
@reckart reckart self-assigned this Aug 19, 2024
- Cleaning up...
- Organize imports and auto-format
@reckart reckart force-pushed the refactoring/379-Clean-up-code branch from bc1bc4a to c387d01 Compare August 28, 2024 10:23
* main:
  Issue #382: Warning when PEAR contains a JCAS class that is used as a feature range outside the PEAR
  Issue #382: Warning when PEAR contains a JCAS class that is used as a feature range outside the PEAR
  Issue #382: Warning when PEAR contains a JCAS class that is used as a feature range outside the PEAR
  Issue #382: Warning when PEAR contains a JCAS class that is used as a feature range outside the PEAR
  Issue #371: Repeated creation of type systems can exhaust JVM metaspace
  Issue #371: Repeated creation of type systems can exhaust JVM metaspace

% Conflicts:
%	uimaj-core/src/main/java/org/apache/uima/cas/CASRuntimeException.java
%	uimaj-core/src/main/java/org/apache/uima/cas/impl/FSClassRegistry.java
* main:
  Issue #382: Warning when PEAR contains a JCAS class that is used as a feature range outside the PEAR
- Clean up
- Some upgrading to AssertJ
- Sort modifiers
- Auto-format
- Clean up more
- Move more tests to AssertJ
- Convert package.html to package-info.java
- Clean up
- Auto-format
- Make some previously final fields in CASImpl package private and non-final so they can be influenced by a test
@reckart reckart force-pushed the refactoring/379-Clean-up-code branch from 917dcf4 to b746af2 Compare August 30, 2024 09:23
- Clean up
- Auto-format
- Fix index protection tests
@reckart reckart force-pushed the refactoring/379-Clean-up-code branch from b23dad8 to 7270128 Compare September 2, 2024 12:10
@reckart reckart merged commit 1994048 into main Sep 4, 2024
1 check passed
@reckart reckart deleted the refactoring/379-Clean-up-code branch September 4, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Refactoring Improvement for development or maintainability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant