Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-1802] Add node events #573

Closed
wants to merge 5 commits into from
Closed

Conversation

pbacsko
Copy link
Contributor

@pbacsko pbacsko commented Jun 19, 2023

What is this PR for?

Create wrapper type for node events and integrate it with the existing codebase.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-1802

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@pbacsko pbacsko self-assigned this Jun 19, 2023
@pbacsko pbacsko marked this pull request as draft June 19, 2023 20:22
@pbacsko pbacsko force-pushed the YUNIKORN-1802 branch 3 times, most recently from e4b4b34 to b4bf21e Compare June 19, 2023 20:33
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #573 (e17e434) into master (9bc3a5e) will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
+ Coverage   76.41%   76.61%   +0.19%     
==========================================
  Files          74       75       +1     
  Lines       12212    12299      +87     
==========================================
+ Hits         9332     9423      +91     
+ Misses       2569     2565       -4     
  Partials      311      311              
Impacted Files Coverage Δ
pkg/scheduler/context.go 30.63% <100.00%> (+0.20%) ⬆️
pkg/scheduler/objects/application_events.go 100.00% <100.00%> (ø)
pkg/scheduler/objects/node.go 84.16% <100.00%> (+1.56%) ⬆️
pkg/scheduler/objects/node_events.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pbacsko pbacsko marked this pull request as ready for review June 19, 2023 20:40
@pbacsko
Copy link
Contributor Author

pbacsko commented Jun 19, 2023

cc @FrankYang0529 you might need some stuff from this PR, like MockEventSystem. If this gets merged, you can rebase your PR on this. Let's make sure that our changes (methods, test cases, approaches, etc.) look similar for consistency.

@pbacsko pbacsko changed the title [YUNIKORN-1802] Add wrapper for node events [YUNIKORN-1802] Add node events Jun 22, 2023
pkg/events/events.go Outdated Show resolved Hide resolved
pkg/scheduler/objects/node.go Show resolved Hide resolved
@wilfred-s
Copy link
Contributor

PR needs a rebase after other event changes have been committed.

@pbacsko pbacsko requested a review from wilfred-s June 23, 2023 09:13
Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor point on locking

pkg/scheduler/objects/node.go Show resolved Hide resolved
@pbacsko pbacsko closed this in b11eb14 Jun 29, 2023
@pbacsko pbacsko deleted the YUNIKORN-1802 branch December 7, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants