Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-1827] Add core.application.usage logger #575

Closed
wants to merge 1 commit into from

Conversation

craigcondit
Copy link
Contributor

Log the messages added by YUNIKORN-1385 (application aggregated resource tracking) so that they may be selectively enabled/disabled.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-1827

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@craigcondit craigcondit self-assigned this Jun 20, 2023
Log the messages added by YUNIKORN-1385 (application aggregated resource
tracking) so that they may be selectively enabled/disabled.
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #575 (ae58523) into master (a6a90bb) will increase coverage by 0.12%.
The diff coverage is 84.33%.

@@            Coverage Diff             @@
##           master     #575      +/-   ##
==========================================
+ Coverage   75.45%   75.58%   +0.12%     
==========================================
  Files          73       74       +1     
  Lines       12057    12137      +80     
==========================================
+ Hits         9098     9174      +76     
- Misses       2638     2642       +4     
  Partials      321      321              
Impacted Files Coverage Δ
pkg/log/filtered_core.go 43.75% <43.75%> (ø)
pkg/webservice/handlers.go 80.26% <66.66%> (+0.46%) ⬆️
pkg/log/logger.go 88.96% <85.96%> (+9.47%) ⬆️
pkg/common/configs/configs.go 85.18% <100.00%> (+1.51%) ⬆️
pkg/scheduler/objects/application.go 65.41% <100.00%> (ø)
pkg/scheduler/objects/node.go 82.60% <100.00%> (+0.04%) ⬆️
pkg/scheduler/placement/filter.go 89.83% <100.00%> (+0.08%) ⬆️
pkg/scheduler/placement/placement.go 83.21% <100.00%> (-0.13%) ⬇️
pkg/webservice/state_dump.go 70.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@craigcondit craigcondit deleted the YUNIKORN-1827 branch June 20, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants