Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2694] Improve placement rule funtion's test coverage #899

Closed
wants to merge 1 commit into from

Conversation

SP12893678
Copy link
Contributor

What is this PR for?

Improve placement rule funtion's test coverage
The placement code will now have full coverage.

  • placement_test.go
  • provided_rule_test.go
  • rule_test.go

What type of PR is it?

  • - Test

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2694

@SP12893678 SP12893678 force-pushed the YUNIKORN-2694 branch 2 times, most recently from 3a398c7 to b91fb0b Compare June 23, 2024 05:12
@wilfred-s
Copy link
Contributor

Please check the changes in PR #891 as things might clash with this PR.

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.48%. Comparing base (67a7167) to head (2684584).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #899      +/-   ##
==========================================
+ Coverage   78.24%   78.48%   +0.23%     
==========================================
  Files          97       97              
  Lines       12210    12210              
==========================================
+ Hits         9554     9583      +29     
+ Misses       2350     2329      -21     
+ Partials      306      298       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SP12893678
Copy link
Contributor Author

Please check the changes in PR #891 as things might clash with this PR.

Oh, it might happen.
I will rebase the latest commit and retest it after PR #891 is merged.

@pbacsko pbacsko self-requested a review June 24, 2024 13:22
Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some minor things

pkg/scheduler/placement/rule_test.go Outdated Show resolved Hide resolved
pkg/scheduler/placement/rule_test.go Outdated Show resolved Hide resolved
pkg/scheduler/placement/rule_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@manirajv06 manirajv06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#891 has gone in. Can you rebase and resolve conflicts?

@SP12893678
Copy link
Contributor Author

#891 has gone in. Can you rebase and resolve conflicts?

Sure! Please take a look.
I also append new test case for new code from testrule.go

@pbacsko
Copy link
Contributor

pbacsko commented Jun 25, 2024

+1

@pbacsko pbacsko closed this in 9519f7c Jun 25, 2024
@SP12893678 SP12893678 deleted the YUNIKORN-2694 branch June 27, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants