-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-2694] Improve placement rule funtion's test coverage #899
Conversation
3a398c7
to
b91fb0b
Compare
Please check the changes in PR #891 as things might clash with this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #899 +/- ##
==========================================
+ Coverage 78.24% 78.48% +0.23%
==========================================
Files 97 97
Lines 12210 12210
==========================================
+ Hits 9554 9583 +29
+ Misses 2350 2329 -21
+ Partials 306 298 -8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some minor things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#891 has gone in. Can you rebase and resolve conflicts?
b91fb0b
to
a76de1f
Compare
a76de1f
to
2684584
Compare
Sure! Please take a look. |
+1 |
What is this PR for?
Improve placement rule funtion's test coverage
The placement code will now have full coverage.
What type of PR is it?
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2694