Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2777] Improve TrackedResource type #928

Closed
wants to merge 1 commit into from

Conversation

pbacsko
Copy link
Contributor

@pbacsko pbacsko commented Aug 2, 2024

What is this PR for?

Refactor TrackedResource type so that we can re-use code for *Resource if needed.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2777

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@pbacsko pbacsko self-assigned this Aug 2, 2024
@pbacsko pbacsko marked this pull request as draft August 2, 2024 07:19
@pbacsko pbacsko force-pushed the YUNIKORN-2777 branch 3 times, most recently from 124b008 to bcadd1a Compare August 2, 2024 07:40
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.24%. Comparing base (0792325) to head (b0a0592).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/common/resources/tracked_resources.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #928      +/-   ##
==========================================
+ Coverage   79.22%   79.24%   +0.01%     
==========================================
  Files          97       97              
  Lines       12293    12285       -8     
==========================================
- Hits         9739     9735       -4     
+ Misses       2268     2266       -2     
+ Partials      286      284       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pbacsko pbacsko marked this pull request as ready for review August 2, 2024 13:36
Copy link
Contributor

@zhuqi-lucas zhuqi-lucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/scheduler/partition_test.go Show resolved Hide resolved
@pbacsko pbacsko closed this in 9c601bd Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants