Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-439]Parse taskGroup info from pod annotation #204

Merged
merged 4 commits into from
Oct 30, 2020

Conversation

HuangTing-Yao
Copy link
Contributor

Parse taskGroups info from pod annotation.
Please review @yangwwei
Thanks.

@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

❗ No coverage uploaded for pull request base (YUNIKORN-2@e2ce948). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             YUNIKORN-2     #204   +/-   ##
=============================================
  Coverage              ?   59.47%           
=============================================
  Files                 ?       36           
  Lines                 ?     3104           
  Branches              ?        0           
=============================================
  Hits                  ?     1846           
  Misses                ?     1181           
  Partials              ?       77           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2ce948...162b290. Read the comment docs.

@yangwwei
Copy link
Contributor

hi @HuangTing-Yao

I just get #203 merged, could you please rebase this.
Like offline discussed, could you please modify the type of nodeSelector to a map? that will be consistent with the podSpec

@@ -61,7 +61,7 @@ type TaskGroup struct {
        Name         string                       `json:"name"`
        MinMember    int32                        `json:"minMember"`
        MinResource  map[string]resource.Quantity `json:"minResource"`
-       NodeSelector metav1.LabelSelector         `json:"nodeSelector,omitempty"`
+       NodeSelector map[string]string            `json:"nodeSelector,omitempty"`
        Tolerations  []v1.Toleration              `json:"tolerations,omitempty"`
 }

@yangwwei yangwwei merged commit e78ce07 into apache:YUNIKORN-2 Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants