[YUNIKORN-459]Implement the placeholder cleanup in PlaceholderManager #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## YUNIKORN-2 #207 +/- ##
=============================================
Coverage ? 59.23%
=============================================
Files ? 36
Lines ? 3120
Branches ? 0
=============================================
Hits ? 1848
Misses ? 1192
Partials ? 80 Continue to review full report at Codecov.
|
yangwwei
reviewed
Nov 25, 2020
pkg/cache/placeholder_manager.go
Outdated
Comment on lines
86
to
90
| err = app.removeTask(taskID) | ||
| if err != nil { | ||
| log.Logger().Error("failed to remove task from application", | ||
| zap.Error(err)) | ||
| } |
There was a problem hiding this comment.
second thought, let's remove this. We do not need to remove the task from the app while cleaning up the placeholders. Task needs to be cleaned up separately, the normal process involves the core side to release corresponding resources in the scheduler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up all placeholder pod and task.
Please review @yangwwei
Thanks.