-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-1280] Shim side changes for YUNIKORN-1275 #450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we split the tests for annotations into 3 tests:
- test annotations based on the new setup (new function)
- mixed new and deprecated (new function)
- deprecated annotation (existing test)
Makes checks and regressions easier to track down.
b65107c
to
e92c1b1
Compare
e92c1b1
to
a6b8137
Compare
Taken care |
Codecov Report
@@ Coverage Diff @@
## master #450 +/- ##
==========================================
- Coverage 67.24% 67.00% -0.25%
==========================================
Files 41 41
Lines 6722 6767 +45
==========================================
+ Hits 4520 4534 +14
- Misses 2032 2062 +30
- Partials 170 171 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is this PR for?
Shim side changes to support arbitrary resources in namespace annotation.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1280
How should this be tested?
Screenshots (if appropriate)
Questions: