[YUNIKORN-2623] Create unit tests for Clients #839
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #839 +/- ##
==========================================
+ Coverage 66.06% 67.29% +1.22%
==========================================
Files 69 70 +1
Lines 7550 7592 +42
==========================================
+ Hits 4988 5109 +121
+ Misses 2350 2271 -79
Partials 212 212 ☔ View full report in Codecov by Sentry. |
pbacsko
requested review from
brandboat,
chia7712,
wilfred-s,
craigcondit and
chenyulin0719
chia7712
reviewed
May 13, 2024
| noOfInformers = 9 | ||
| ) | ||
|
|
||
| func TestWaitForSync(t *testing.T) { |
There was a problem hiding this comment.
Maybe we can do a bit refactor to Clients to simplify the test.
- add a new method
informerstoClientsto return all informers - rewrite
WaitForSyncandRunby looping all informers - in this test we can create a mock clients to override the new method
informersto return a single mock informer
WDYT?
There was a problem hiding this comment.
Could we do it a separate ticket? In this one I'd rather just focus on the new tests.
There was a problem hiding this comment.
ok, I have filed https://issues.apache.org/jira/browse/YUNIKORN-2625
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Create mock for
SharedIndexedInformerand update existing types.Write new unit tests for
client.Clients.What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2623
How should this be tested?
Screenshots (if appropriate)
Questions: