Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-1351] alway prefer annotations above labels #337

Closed
wants to merge 1 commit into from

Conversation

chenyulin0719
Copy link
Contributor

What is this PR for?

  1. Add description for new annotation 'disable-state-aware'.
  2. Correct the priority descriptions. (Annotation > Label)
  3. Fix typo.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

NA

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-1351

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - I added one more <br> to make the annotation/label priority description less crowded. Please let me know if it's not suggested.

@wilfred-s
Copy link
Contributor

In the time that this PR has been open the text has been translated and the zh-cn file does not match anymore.
Also please make sure you do a format on the table. The table shows a warning that it is not properly formatted when loaded in an IDE. We try to keep the tables nicely aligned even in the base text format:

| ID | name                                            |
|----|-------------------------------------------------| 
| 1  | a value that also aligns in monospaced raw text |

@chenyulin0719
Copy link
Contributor Author

Hi @wilfred-s,
I've manually formatted the table in 'en' document.
However, the 'zh-cn' word's width is not consistent with 'en', so I can't do the format here.

image

Ex:
image

-> Unable to format 'zh-cn' table by adding space here.

@chenyulin0719
Copy link
Contributor Author

chenyulin0719 commented Oct 31, 2023

Hi @wilfred-s,
May I know which IDE/Plugging you're using? I just want to know how to check the warning of Markdown files?

The table shows a warning that it is not properly formatted when loaded in an IDE.

@wilfred-s
Copy link
Contributor

I currently use Goland or Webstorm both are from JetBrains
They have a number of ways to get a free license

@chenyulin0719
Copy link
Contributor Author

Pushed a new version after formated in Goland.

@chenyulin0719
Copy link
Contributor Author

Close it as new policy for labels and annotations is defined in YUNIKORN-1351.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants