Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2422] Web: create reproducible binaries #172

Closed
wants to merge 1 commit into from

Conversation

craigcondit
Copy link
Contributor

@craigcondit craigcondit commented Feb 15, 2024

What is this PR for?

Ensure that yunikorn-web binary uses consistent build ID and build date so that builds are reproducible.

The git commit timestamp is used (if possible) for the build date, and cached in the build.date file so that it can be included in release tarballs. The go-generated build ID is set to an empty string.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2422

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

Ensure that yunikorn-web binary uses consistent build ID
and build date so that builds are reproducible.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (97bbdd9) 73.07% compared to head (95c3472) 73.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #172   +/-   ##
=======================================
  Coverage   73.07%   73.07%           
=======================================
  Files           1        1           
  Lines          26       26           
=======================================
  Hits           19       19           
  Misses          4        4           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@craigcondit craigcondit deleted the YUNIKORN-2422 branch February 15, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants