Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEPPELIN-1400. Use relative path to the interpreter setting page #1417

Closed
wants to merge 1 commit into from

Conversation

zjffdu
Copy link
Contributor

@zjffdu zjffdu commented Sep 9, 2016

What is this PR for?

Change the url of interpreter page to relative path

What type of PR is it?

[Improvement]

Todos

  • - Task

What is the Jira issue?

How should this be tested?

Build it and open interpreter page.

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@zjffdu
Copy link
Contributor Author

zjffdu commented Sep 9, 2016

@minahlee Please help review.

@prabhjyotsingh
Copy link
Contributor

LGTM!

@corneadoug
Copy link
Contributor

Tested, its also the only link that was not relative.
Merging if there is no more discussions

@asfgit asfgit closed this in 70bec2b Sep 11, 2016
asfgit pushed a commit that referenced this pull request Sep 11, 2016
### What is this PR for?
Change the url of interpreter page to relative path

### What type of PR is it?
[Improvement]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1400

### How should this be tested?
Build it and open interpreter page.

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jeff Zhang <zjffdu@apache.org>

Closes #1417 from zjffdu/ZEPPELIN-1400 and squashes the following commits:

70c90d5 [Jeff Zhang] ZEPPELIN-1400. Use relative path to the interpreter setting page

(cherry picked from commit 70bec2b)
Signed-off-by: Damien CORNEAU <corneadoug@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants