Hive proxy user doesn't work if interpreter name is not JDBC #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! LGTM! |
felixcheung
reviewed
Feb 7, 2017
| @@ -375,7 +375,7 @@ public Connection getConnection(String propertyKey, InterpreterContext interpret | |||
| if (user == null) { | |||
| connection = getConnectionFromPool(url, user, propertyKey, properties); | |||
| } else { | |||
| if ("hive".equalsIgnoreCase(propertyKey)) { | |||
| if (url.trim().indexOf("jdbc:hive") == 0) { | |||
There was a problem hiding this comment.
should it do startsWith instead?
|
@felixcheung updated in 6d55d48 |
|
Merging this to master and branch-0.7 if no more discussion. |
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Feb 13, 2017
### What is this PR for? Hive proxy user doesn't work if interpreter name is not JDBC ### What type of PR is it? Bug Fix ### Todos * [ ] - Task ### What is the Jira issue? [ZEPPELIN-2062](https://issues.apache.org/jira/browse/ZEPPELIN-2062) ### How should this be tested? Create a new interpreter named "hive" and run a hive query in a Kerberos environment. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? n/a * Is there breaking changes for older versions? n/a * Does this needs documentation? n/a Author: Renjith Kamath <renjith.kamath@gmail.com> Closes #1978 from r-kamath/ZEPPELIN-2062 and squashes the following commits: 6d55d48 [Renjith Kamath] ZEPPELIN-2062 review fix 8c97c7b [Renjith Kamath] ZEPPELIN-2062 Hive proxy user doesn't work if interpreter name is not JDBC (cherry picked from commit 5853dd2) Signed-off-by: Prabhjyot Singh <prabhjyotsingh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Hive proxy user doesn't work if interpreter name is not JDBC
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
ZEPPELIN-2062
How should this be tested?
Create a new interpreter named "hive" and run a hive query in a Kerberos environment.
Screenshots (if appropriate)
Questions: