ZEPPELIN-2148: On creation of Bar graph zeppelin UI shows it as mini graph #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@1ambda @Leemoonsoo Help review this. This fixes the problem, but with a dirty hack. |
r-kamath
reviewed
Feb 24, 2017
| @@ -267,7 +267,9 @@ function ResultCtrl($scope, $rootScope, $route, $window, $routeParams, $location | |||
|
|
|||
| $scope.renderDefaultDisplay = function(targetElemId, type, data, refresh) { | |||
| if (type === DefaultDisplayType.TABLE) { | |||
| $scope.renderGraph(targetElemId, $scope.graphMode, refresh); | |||
| setTimeout(function() { | |||
|
Thank you for reviewing @r-kamath. I've handled it. |
|
Merging this to master and branch-0.7 if no more discussion. |
|
On retrying the same build, CI is green now https://travis-ci.org/prabhjyotsingh/zeppelin/builds/204865706 |
|
There were conflicts, will create a new PR for branch-0.7. |
prabhjyotsingh
added a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
Mar 3, 2017
…graph ### What is this PR for? On creation of Bar graph zeppelin UI shows it as mini graph, and is easily reproducible on safari. ### What type of PR is it? [Bug Fix] ### What is the Jira issue? * [ZEPPELIN-2148](https://issues.apache.org/jira/browse/ZEPPELIN-2148) ### How should this be tested? Check screen shot. ### Screenshots (if appropriate) Before:  After:  ### Questions: * Does the licenses files need update? N/A * Is there breaking changes for older versions? N/A * Does this needs documentation? N/A Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Closes apache#2063 from prabhjyotsingh/ZEPPELIN-2148 and squashes the following commits: bb66897 [Prabhjyot Singh] replace setTimeOut with $timeout 38a1198 [Prabhjyot Singh] ZEPPELIN-2148: On creation of Bar graph zeppelin UI shows it as mini graph (reverted from commit 47a106a)
Remilito
pushed a commit
to Remilito/zeppelin
that referenced
this pull request
Mar 3, 2017
…graph ### What is this PR for? On creation of Bar graph zeppelin UI shows it as mini graph, and is easily reproducible on safari. ### What type of PR is it? [Bug Fix] ### What is the Jira issue? * [ZEPPELIN-2148](https://issues.apache.org/jira/browse/ZEPPELIN-2148) ### How should this be tested? Check screen shot. ### Screenshots (if appropriate) Before:  After:  ### Questions: * Does the licenses files need update? N/A * Is there breaking changes for older versions? N/A * Does this needs documentation? N/A Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Closes apache#2063 from prabhjyotsingh/ZEPPELIN-2148 and squashes the following commits: bb66897 [Prabhjyot Singh] replace setTimeOut with $timeout 38a1198 [Prabhjyot Singh] ZEPPELIN-2148: On creation of Bar graph zeppelin UI shows it as mini graph
asfgit
pushed a commit
that referenced
this pull request
Mar 4, 2017
…raph ### What is this PR for? This is an extension #2063. Since that had a merge conflict. ### What type of PR is it? [Bug Fix] ### What is the Jira issue? * [ZEPPELIN-2148](https://issues.apache.org/jira/browse/ZEPPELIN-2148) ### How should this be tested? Check screen shot. ### Screenshots (if appropriate) Before:  After:  ### Questions: * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Closes #2074 from prabhjyotsingh/ZEPPELIN-2148_branch-0.7 and squashes the following commits: dbd5b34 [Prabhjyot Singh] try 2 ca1ea2e [Prabhjyot Singh] ZEPPELIN-2148: On creation of Bar graph zeppelin UI shows it as minigraph
prabhjyotsingh
added a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
Mar 7, 2017
…raph ### What is this PR for? This is an extension apache#2063. Since that had a merge conflict. ### What type of PR is it? [Bug Fix] ### What is the Jira issue? * [ZEPPELIN-2148](https://issues.apache.org/jira/browse/ZEPPELIN-2148) ### How should this be tested? Check screen shot. ### Screenshots (if appropriate) Before:  After:  ### Questions: * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Closes apache#2074 from prabhjyotsingh/ZEPPELIN-2148_branch-0.7 and squashes the following commits: dbd5b34 [Prabhjyot Singh] try 2 ca1ea2e [Prabhjyot Singh] ZEPPELIN-2148: On creation of Bar graph zeppelin UI shows it as minigraph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
On creation of Bar graph zeppelin UI shows it as mini graph, and is easily reproducible on safari.
What type of PR is it?
[Bug Fix]
What is the Jira issue?
How should this be tested?
Check screen shot.
Screenshots (if appropriate)
Before:
After:
Questions: