[ZEPPELIN-2164] Typo in Insufficient Privileges popup of Zeppelin #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Leemoonsoo help review this. |
|
LGTM |
felixcheung
approved these changes
Feb 24, 2017
|
LGTM |
|
Merging this to master and branch-0.7 if no more discussion. |
|
On re-triggering CI is green now. https://travis-ci.org/prabhjyotsingh/zeppelin/builds/204868665. |
|
@prabhjyotsingh FYI, you can change the red light to the green by closing and reopening this PR :) |
asfgit
pushed a commit
that referenced
this pull request
Feb 27, 2017
### What is this PR for? When trying to delete a note of another user Zeppelin correctly throws a popup for insufficient privileges but has a small typo "removenote" (no space between remove note). Similar issue exist for renaming notebook "renamenote". ### What type of PR is it? [Bug Fix] ### What is the Jira issue? * [ZEPPELIN-2164](https://issues.apache.org/jira/browse/ZEPPELIN-2164) ### How should this be tested? Refer before/after screen shot ### Screenshots (if appropriate) Before: <img width="628" alt="screen shot 2017-02-24 at 11 49 59 am 1" src="https://cloud.githubusercontent.com/assets/674497/23292690/66b808fa-fa87-11e6-9bde-4f9fbbb1cb67.png"> After: <img width="645" alt="screen shot 2017-02-24 at 11 48 35 am" src="https://cloud.githubusercontent.com/assets/674497/23292691/66c0e9c0-fa87-11e6-9abc-16dc7b52ce3c.png"> ### Questions: * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Closes #2064 from prabhjyotsingh/ZEPPELIN-2164 and squashes the following commits: c4c8222 [Prabhjyot Singh] ZEPPELIN-2164: Typo in Insufficient Privileges popup of Zeppelin (cherry picked from commit 5da963e) Signed-off-by: Prabhjyot Singh <prabhjyotsingh@gmail.com>
Remilito
pushed a commit
to Remilito/zeppelin
that referenced
this pull request
Mar 3, 2017
### What is this PR for? When trying to delete a note of another user Zeppelin correctly throws a popup for insufficient privileges but has a small typo "removenote" (no space between remove note). Similar issue exist for renaming notebook "renamenote". ### What type of PR is it? [Bug Fix] ### What is the Jira issue? * [ZEPPELIN-2164](https://issues.apache.org/jira/browse/ZEPPELIN-2164) ### How should this be tested? Refer before/after screen shot ### Screenshots (if appropriate) Before: <img width="628" alt="screen shot 2017-02-24 at 11 49 59 am 1" src="https://cloud.githubusercontent.com/assets/674497/23292690/66b808fa-fa87-11e6-9bde-4f9fbbb1cb67.png"> After: <img width="645" alt="screen shot 2017-02-24 at 11 48 35 am" src="https://cloud.githubusercontent.com/assets/674497/23292691/66c0e9c0-fa87-11e6-9abc-16dc7b52ce3c.png"> ### Questions: * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Closes apache#2064 from prabhjyotsingh/ZEPPELIN-2164 and squashes the following commits: c4c8222 [Prabhjyot Singh] ZEPPELIN-2164: Typo in Insufficient Privileges popup of Zeppelin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
When trying to delete a note of another user Zeppelin correctly throws a popup for insufficient privileges but has a small typo "removenote" (no space between remove note). Similar issue exist for renaming notebook "renamenote".
What type of PR is it?
[Bug Fix]
What is the Jira issue?
How should this be tested?
Refer before/after screen shot
Screenshots (if appropriate)
Before:
After:
Questions: