Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-2202] Disable personalized mode btn when note is running (master) #2108

Conversation

1ambda
Copy link
Member

@1ambda 1ambda commented Mar 7, 2017

What is this PR for?

Disable the personalized mode button when a note is running.

What type of PR is it?

[Improvement]

Todos

NONE

What is the Jira issue?

ZEPPELIN-2202

How should this be tested?

Refer the screenshot below.

Screenshots (if appropriate)

2202

Questions:

  • Does the licenses files need update? - NO
  • Is there breaking changes for older versions? - NO
  • Does this needs documentation? - NO

@1ambda
Copy link
Member Author

1ambda commented Mar 7, 2017

@jongyoul Can you help review this?

@jongyoul
Copy link
Member

jongyoul commented Mar 9, 2017

Tested. LGTM. Merging if there's no more discussion

@1ambda
Copy link
Member Author

1ambda commented Mar 10, 2017

This is the same fix for branch-0.7

@asfgit asfgit closed this in 5d2ce18 Mar 14, 2017
asfgit pushed a commit that referenced this pull request Mar 14, 2017
…ranch-0.7)

### What is this PR for?

Disable the personalized mode button when a note is running.

- The same fix with #2108 for branch-0.7
- CI failure might be related with #2103

### What type of PR is it?
[Improvement]

### Todos

NONE

### What is the Jira issue?

[ZEPPELIN-2202](https://issues.apache.org/jira/browse/ZEPPELIN-2202)

### How should this be tested?

Refer the screenshot below.

### Screenshots (if appropriate)

![2202](https://cloud.githubusercontent.com/assets/4968473/23661339/c45dcd9e-038f-11e7-9551-6cde925aa5f4.gif)

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO

Author: 1ambda <1amb4a@gmail.com>

Closes #2115 from 1ambda/disable-person-mode-btn-when-note-is-running-for-070 and squashes the following commits:

5e0f0b0 [1ambda] feat: disable person mode btn when running
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants