[ZEPPELIN-2175] Jdbc interpreter sometime doesn't show detailed error message #2122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixcheung
approved these changes
Mar 14, 2017
|
CI is green. Please help review this. cc: @Leemoonsoo, @r-kamath, @jongyoul, @cloverhearts, @felixcheung. |
r-kamath
approved these changes
Mar 14, 2017
|
LGTM |
|
Merging this to master and branch-0.7 if no more discussion. |
prabhjyotsingh
changed the title
asfgit
pushed a commit
that referenced
this pull request
Mar 16, 2017
… message ### What is this PR for? Zeppelin's JDBC interpreter sometimes doesn't show detailed error message on the notebook ui. It shows only plain "ERROR" text near run button in case of failure. User has to check JDBC interpreter log file in order to see a detailed error message. This is mostly in case of incompatible JAR and I see errors mentioned below; ``` java.lang.NoSuchMethodError: org.apache.curator.utils.ZKPaths.fixForNamespace(Ljava/lang/String;Ljava/lang/String;Z)Ljava/lang/String; at org.apache.curator.framework.imps.NamespaceImpl.fixForNamespace(NamespaceImpl.java:82) ``` ``` java.lang.NoSuchMethodError: org.apache.hive.service.auth.HiveAuthFactory.getSocketTransport(Ljava/lang/String;II)Lorg/apache/hive/org/apache/thrift/transport/TTransport; at org.apache.hive.jdbc.HiveConnection.createBinaryTransport(HiveConnection.java:447) ``` Hence, IMO instead of catch -> Exception; we should use catch ->Throwable. ### What type of PR is it? [Improvement] ### What is the Jira issue? * [ZEPPELIN-2175](https://issues.apache.org/jira/browse/ZEPPELIN-2175) ### How should this be tested? Use any incompatible in interpreter dependency, which would throw Error instead of Exception. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? N/A * Is there breaking changes for older versions? N/A * Does this needs documentation? N/A Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Closes #2122 from prabhjyotsingh/ZEPPELIN-2175 and squashes the following commits: 666ce8d [Prabhjyot Singh] use Throwable instead of Exception (cherry picked from commit d0fc54b) Signed-off-by: Prabhjyot Singh <prabhjyotsingh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Zeppelin's JDBC interpreter sometimes doesn't show detailed error message on the notebook ui. It shows only plain "ERROR" text near run button in case of failure. User has to check JDBC interpreter log file in order to see a detailed error message.
This is mostly in case of incompatible JAR and I see errors mentioned below;
Hence, IMO instead of catch -> Exception; we should use catch ->Throwable.
What type of PR is it?
[Improvement]
What is the Jira issue?
How should this be tested?
Use any incompatible in interpreter dependency, which would throw Error instead of Exception.
Screenshots (if appropriate)
Questions: